(OLD) (ARCHIVED) Puppy Linux Discussion Forum Forum Index (OLD) (ARCHIVED) Puppy Linux Discussion Forum
Puppy HOME page : puppylinux.com
"THE" alternative forum : puppylinux.info

This forum can also be accessed as http://oldforum.puppylinux.com
It is now read-only and serves only as archives.

Please register over the NEW forum
https://forum.puppylinux.com
and continue your work there. Thank you.

 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups    
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

The time now is Mon 19 Oct 2020, 22:52
All times are UTC - 4
 Forum index » House Training » Bugs ( Submit bugs )
Init Typo
Moderators: Flash, Ian, JohnMurga
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies. View previous topic :: View next topic
Page 1 of 1 [7 Posts]  
Author Message
corvus


Joined: 12 Jun 2015
Posts: 156
Location: In the peninsula shaped like a boot.

PostPosted: Mon 09 Mar 2020, 07:21    Post subject:  Init Typo  

Good morning, I report the following typo in the init file in initrd.gz, found in Bionicpup64 and LxPupSc64, maybe it exists in other versions of Puppy:

Bionicpup64 line 82 -> [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="adrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

LxPupSc64 line 81 -> [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="adrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

I think it should be [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="ydrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

May be of interest to someone.

Best regards

_________________
We are waves of the same sea, leaves of the same tree, flowers of the same garden.
Back to top
View user's profile Send private message 
s243a

Joined: 02 Sep 2014
Posts: 2626

PostPosted: Mon 09 Mar 2020, 11:04    Post subject: Re: Init Typo  

corvus wrote:
Good morning, I report the following typo in the init file in initrd.gz, found in Bionicpup64 and LxPupSc64, maybe it exists in other versions of Puppy:

Bionicpup64 line 82 -> [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="adrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

LxPupSc64 line 81 -> [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="adrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

I think it should be [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="ydrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

May be of interest to someone.

Best regards


Please report the issue here:

https://github.com/puppylinux-woof-CE/woof-CE/issues

or do a pull/merge request. THe file that needs fixing is here:
https://github.com/puppylinux-woof-CE/woof-CE/blob/testing/initrd-progs/0initrd/init

The branch that people work on is the "testing" branch. If you don't get around to reporting this issue I'm sure someone else will (e.g. me) but I would like to encourage people to contribute on github Smile

_________________
Find me on minds and on pearltrees.
Back to top
View user's profile Send private message Visit poster's website 
corvus


Joined: 12 Jun 2015
Posts: 156
Location: In the peninsula shaped like a boot.

PostPosted: Mon 09 Mar 2020, 12:11    Post subject:  

s243a wrote:
Please report the issue here:

https://github.com/puppylinux-woof-CE/woof-CE/issues

or do a pull/merge request. THe file that needs fixing is here:
https://github.com/puppylinux-woof-CE/woof-CE/blob/testing/initrd-progs/0initrd/init

Honestly registering on GitHub just to report a single typo seems a bit exaggerated.

s243a wrote:
If you don't get around to reporting this issue I'm sure someone else will (e.g. me)

It seems to me the best solution. Thanks for your help s243a.

Have a nice day

_________________
We are waves of the same sea, leaves of the same tree, flowers of the same garden.
Back to top
View user's profile Send private message 
rockedge


Joined: 11 Apr 2012
Posts: 1874
Location: Connecticut, United States

PostPosted: Mon 09 Mar 2020, 13:22    Post subject:  

Hello corvus and s243a,

I reported it on github woof-CE site in the Issues section

Nice catch corvus! I just was wondering why a ydrv.sfs wasn't loading at boot.

Thanks....hope all is well in Italy
Back to top
View user's profile Send private message Visit poster's website 
s243a

Joined: 02 Sep 2014
Posts: 2626

PostPosted: Mon 09 Mar 2020, 14:08    Post subject:  

rockedge wrote:
Hello corvus and s243a,

I reported it on github woof-CE site in the Issues section

Nice catch corvus! I just was wondering why a ydrv.sfs wasn't loading at boot.

Thanks....hope all is well in Italy


Thankyou, rockedge and corvus. Smile

_________________
Find me on minds and on pearltrees.
Back to top
View user's profile Send private message Visit poster's website 
corvus


Joined: 12 Jun 2015
Posts: 156
Location: In the peninsula shaped like a boot.

PostPosted: Mon 09 Mar 2020, 14:25    Post subject:  

rockedge wrote:
Thanks....hope all is well in Italy

Thanks rockedge for being interested. Here we live in the moment.

Best regards

_________________
We are waves of the same sea, leaves of the same tree, flowers of the same garden.
Back to top
View user's profile Send private message 
s243a

Joined: 02 Sep 2014
Posts: 2626

PostPosted: Mon 09 Mar 2020, 22:40    Post subject:  

micko fixed this (5hours ago) per the report in the original post. See:

https://github.com/puppylinux-woof-CE/woof-CE/commit/9d290e057d606ae877093d93417df7758ef50734

thankyou for reminding as about this typo Smile

_________________
Find me on minds and on pearltrees.
Back to top
View user's profile Send private message Visit poster's website 
Display posts from previous:   Sort by:   
Page 1 of 1 [7 Posts]  
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies. View previous topic :: View next topic
 Forum index » House Training » Bugs ( Submit bugs )
Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum


Powered by phpBB © 2001, 2005 phpBB Group
[ Time: 0.0954s ][ Queries: 11 (0.0402s) ][ GZIP on ]