Page 1 of 1

Init Typo

Posted: Mon 09 Mar 2020, 11:21
by corvus
Good morning, I report the following typo in the init file in initrd.gz, found in Bionicpup64 and LxPupSc64, maybe it exists in other versions of Puppy:

Bionicpup64 line 82 -> [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="adrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

LxPupSc64 line 81 -> [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="adrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

I think it should be [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="ydrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

May be of interest to someone.

Best regards

Re: Init Typo

Posted: Mon 09 Mar 2020, 15:04
by s243a
corvus wrote:Good morning, I report the following typo in the init file in initrd.gz, found in Bionicpup64 and LxPupSc64, maybe it exists in other versions of Puppy:

Bionicpup64 line 82 -> [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="adrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

LxPupSc64 line 81 -> [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="adrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

I think it should be [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="ydrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

May be of interest to someone.

Best regards
Please report the issue here:

https://github.com/puppylinux-woof-CE/woof-CE/issues

or do a pull/merge request. THe file that needs fixing is here:
https://github.com/puppylinux-woof-CE/w ... nitrd/init

The branch that people work on is the "testing" branch. If you don't get around to reporting this issue I'm sure someone else will (e.g. me) but I would like to encourage people to contribute on github :)

Posted: Mon 09 Mar 2020, 16:11
by corvus
s243a wrote:Please report the issue here:

https://github.com/puppylinux-woof-CE/woof-CE/issues

or do a pull/merge request. THe file that needs fixing is here:
https://github.com/puppylinux-woof-CE/w ... nitrd/init
Honestly registering on GitHub just to report a single typo seems a bit exaggerated.
s243a wrote:If you don't get around to reporting this issue I'm sure someone else will (e.g. me)
It seems to me the best solution. Thanks for your help s243a.

Have a nice day

Posted: Mon 09 Mar 2020, 17:22
by rockedge
Hello corvus and s243a,

I reported it on github woof-CE site in the Issues section

Nice catch corvus! I just was wondering why a ydrv.sfs wasn't loading at boot.

Thanks....hope all is well in Italy

Posted: Mon 09 Mar 2020, 18:08
by s243a
rockedge wrote:Hello corvus and s243a,

I reported it on github woof-CE site in the Issues section

Nice catch corvus! I just was wondering why a ydrv.sfs wasn't loading at boot.

Thanks....hope all is well in Italy
Thankyou, rockedge and corvus. :)

Posted: Mon 09 Mar 2020, 18:25
by corvus
rockedge wrote:Thanks....hope all is well in Italy
Thanks rockedge for being interested. Here we live in the moment.

Best regards

Posted: Tue 10 Mar 2020, 02:40
by s243a
micko fixed this (5hours ago) per the report in the original post. See:

https://github.com/puppylinux-woof-CE/w ... 758ef50734

thankyou for reminding as about this typo :)