Dougal wrote:I tried it and all I could see is that it removed blank lines (which we don't care about). If you want to keep the blank lines, just add a tab or two into each.
Apologies I should have been clearer in my report. Scenario:
I am a naive user, I click
Menu - Desktop - JWM Configuration - OK - Panel Buttons - (the edit button is checked) - OK
I just wanted to see what it did. There are XML comments in some of the fields. I don't want to break anything so I don't change any of the text and just keep clicking the OK buttons. I should be alright because I didn't change anything. The problem is the configurator tries to write back the xml comments into the file. Somewhere in the conversion from xml -> gtkdialog -> xml it gets screwed up.
There is no Cancel, if I try and be a bit clever I use the window manager decoration to close the window but that doesn't help.
here's the start of the resulting .jwmrc-tray
Code: Select all
<JWM>
<Tray autohide="false" insert="right" x="0" y="-1" border="0" height="26" >
<!-- Additional TrayButton attribute: label -->
<TrayButton label="Menu" icon="mini-dog.xpm">root:3</TrayButton>
<TrayButton popup="<!-- BK showdesktop incompatible with rox 2.5... -->" icon=""><!-- BK showdesktop incompatible with rox 2.5... --></TrayButton>
<TrayButton popup="<!-- Dougal: fixed by selecting" icon=""><!-- in Rox --></TrayButton>
<TrayButton popup="Show desktop" icon="showdesk16.xpm">showdesktop</TrayButton>
<TrayButton popup="<!-- Open terminal" icon="mini-sh.xpm"><!-- exec:rxvt --></TrayButton>
<TrayButton popup="<!-- Open text editor" icon="mini-edit.xpm"><!-- exec:defaulttexteditor --></TrayButton>
<!-- <TrayButton popup="Open text editor" icon="mini-edit.xpm">exec:defaulttexteditor</TrayButton> -->
<!-- Additional Pager attributes; width, height -->
<Pager/>
I think the problem is caused because ....jwmconfig/panel-buttons assumes that every line after the menu button declaration is a valid panel button until it hits the pager declaration. A good example of why editing xml without a proper parser is dangerous! I'm not pointing the finger, I would do the some thing for simplicity.