Later JWM versions are improving, fullscreen bugs fixed, screen rotation.. but there is a compositing bug which Joe is working on.
-
Ok.. there is a "bug" with your nifty samba share rox app.. and it only occurs when mounting a Mac share [
]. ( I might "steal" this one
)
My wife has a macbook and the sharename is "Kriista's Public Folder" .. yeah trust mac devs to whack in spaces and an apostrophe for good measure!
Any way, I patched the rox app for my purposes and it seems to work fine. I'll offer the patch FWIW, so anyone who knows what they're doing can patch and use with a mac. It doesn't break windows share mount with my limited testing, but, I could have introduced something.. as there appear a lot of "mounts" for my son's windows 7 machine which aren't really shares.
Also, I made a cool overlay that I use as a "mount" icon. Attached.
Patch:
Code: Select all
diff -ru /aufs/pup_ro/usr/share/Shares/Network/AppRun /usr/share/Shares/Network/AppRun
--- /aufs/pup_ro/usr/share/Shares/Network/AppRun 2012-05-02 08:52:10.000000000 +0000
+++ /usr/share/Shares/Network/AppRun 2012-05-27 07:18:09.140193879 +0000
@@ -90,20 +90,21 @@
smbclient -U $Username%$Password -g -L $IP | grep Disk | cut -d "|" -f 2 > ${TMP}shares
NAME=$(nmblookup -A $IP | grep "<20>" | cut -d " " -f 1 | sed 's/^[ \t]*//') #couldn't reliably grep server name from smbclient.
-for SHARE in $(cat ${TMP}shares) ; do #Make rox app for each share.
-SHARE2=$(echo $SHARE | sed 's/[!@#\$%^&*()]//g') #remove some ugly characters
-mkdir $MNTDIR/$NAME"--"$SHARE2
-cp $APPDIR/icons/* $MNTDIR/$NAME"--"$SHARE2/
-cp $APPDIR/icons/.DirIcon $MNTDIR/$NAME"--"$SHARE2/
-cat $APPDIR/scripts/part1 > $MNTDIR/$NAME"--"$SHARE2/AppRun
-echo "Name="${NAME[$I]} >> $MNTDIR/$NAME"--"$SHARE2/AppRun
-echo "Share="$SHARE >> $MNTDIR/$NAME"--"$SHARE2/AppRun
-echo "Username="$Username >> $MNTDIR/$NAME"--"$SHARE2/AppRun
-echo "Password="$Password >> $MNTDIR/$NAME"--"$SHARE2/AppRun
-echo "IOCHARSET="$IOCHARSET >> $MNTDIR/$NAME"--"$SHARE2/AppRun
-cat $APPDIR/scripts/part2 >> $MNTDIR/$NAME"--"$SHARE2/AppRun
-cp $APPDIR/scripts/AppInfo.xml $MNTDIR/$NAME"--"$SHARE2/
-chmod -R 755 $MNTDIR/$NAME"--"$SHARE2
+for SHARE in $(cat ${TMP}shares|sed 's/ /___/g') ; do #Make rox app for each share.
+SHARE2=$(echo "$SHARE" | sed -e 's/[!@#\$%^&*()]//g' \
+ -e 's/___/ /g') #remove some ugly characters and replace space with underscore
+mkdir $MNTDIR/$NAME"--""$SHARE2"
+cp $APPDIR/icons/* $MNTDIR/$NAME"--""$SHARE2"/
+cp $APPDIR/icons/.DirIcon $MNTDIR/$NAME"--""$SHARE2"/
+cat $APPDIR/scripts/part1 > $MNTDIR/$NAME"--""$SHARE2"/AppRun
+echo "Name="${NAME[$I]} >> $MNTDIR/$NAME"--""$SHARE2"/AppRun
+echo "Share=""\"$SHARE2\"" >> $MNTDIR/$NAME"--""$SHARE2"/AppRun
+echo "Username="$Username >> $MNTDIR/$NAME"--""$SHARE2"/AppRun
+echo "Password="$Password >> $MNTDIR/$NAME"--""$SHARE2"/AppRun
+echo "IOCHARSET="$IOCHARSET >> $MNTDIR/$NAME"--""$SHARE2"/AppRun
+cat $APPDIR/scripts/part2 >> $MNTDIR/$NAME"--""$SHARE2"/AppRun
+cp $APPDIR/scripts/AppInfo.xml $MNTDIR/$NAME"--""$SHARE2"/
+chmod -R 755 $MNTDIR/$NAME"--""$SHARE2"
done
done
killall yaf-splash
diff -ru /aufs/pup_ro/usr/share/Shares/Network/scripts/part2 /usr/share/Shares/Network/scripts/part2
--- /aufs/pup_ro/usr/share/Shares/Network/scripts/part2 2012-05-02 08:52:10.000000000 +0000
+++ /usr/share/Shares/Network/scripts/part2 2012-05-27 10:02:38.710681980 +0000
@@ -7,33 +7,34 @@
fi
-if [ "$(mount | grep $Name )" = "" ] ; then #for some reason can't grep $APPDIR when used as a rox app, guess it's something with /.
+if [ "$(mount | grep $Name )" = "" ] ; then #for some reason can't grep "$APPDIR" when used as a rox app, guess it's something with /.
[ "$PARAMS" = "unmount" ] && exit
- mkdir $APPDIR/mnt-point
+ mkdir "$APPDIR"/mnt-point
IP=$(nmblookup $Name | grep "<00>" | cut -d " " -f 1) #Ip address my change so look it up by netbios name.
- mount.cifs "//$IP/$Share" "$APPDIR/mnt-point" -o "$Name,username=$Username,password=$Password,noserverino$IOCHARSET"
+ echo "mount.cifs "//$IP/\"$Share\"" "mnt-point" -o "$Name,username=$Username,password=$Password,noserverino$IOCHARSET"" > /tmp/trymount
+ . /tmp/trymount
if [ $? -ne 0 ]; then
Xdialog --title "$APPTITLE" --stdout --ok-label "OK" --infobox "Could not mount the shared folder." 0 0 90000
exit
else
- rox $APPDIR/mnt-point
- cp $APPDIR/drive_mntd48.png $APPDIR/.DirIcon
- rox -x $(echo $APPDIR | sed 's,/*[^/]\+/*$,,') #refresh window so new icon shows up.
+ rox "$APPDIR"/mnt-point
+ cp "$APPDIR"/drive_mntd48.png "$APPDIR"/.DirIcon
+ rox -x $(echo "$APPDIR" | sed 's,/*[^/]\+/*$,,') #refresh window so new icon shows up.
fi
else #if already mounted
if [ "$PARAMS" = "unmount" ] ; then
-rox -D $APPDIR/mnt-point
-umount.cifs $APPDIR/mnt-point
+rox -D "$APPDIR"/mnt-point
+umount.cifs mnt-point #no need for $APPDIR
if [ $? -ne 0 ]; then
Xdialog --title "$APPTITLE" --stdout --ok-label "OK" --infobox "Could not umount. Close all files open on the shared folder and try again." 0 0 90000
- cp $APPDIR/drive_mntd48.png $APPDIR/.DirIcon
- rox -x $(echo $APPDIR | sed 's,/*[^/]\+/*$,,')
+ cp "$APPDIR"/drive_mntd48.png "$APPDIR"/.DirIcon
+ rox -x $(echo "$APPDIR" | sed 's,/*[^/]\+/*$,,')
exit
else
- cp $APPDIR/drive48.png $APPDIR/.DirIcon
- rox -x $(echo $APPDIR | sed 's,/*[^/]\+/*$,,')
+ cp "$APPDIR"/drive48.png "$APPDIR"/.DirIcon
+ rox -x $(echo "$APPDIR" | sed 's,/*[^/]\+/*$,,')
fi
else
-rox $APPDIR/mnt-point
-fi
+rox "$APPDIR"/mnt-point
fi
+fi
\ No newline at end of file
Cheers
EDIT.. hmm.. can't add attachment.. ownership maybe?
Added later in slacko